aminghadersohi commented on code in PR #40746: URL: https://github.com/apache/superset/pull/40746#discussion_r3390842214
########## superset/mcp_service/user/schemas.py: ########## @@ -19,9 +19,12 @@ from __future__ import annotations +import logging from datetime import datetime, timezone from typing import Annotated, Any, List, Literal +logger = logging.getLogger(__name__) Review Comment: **high:** `logger = logging.getLogger(__name__)` is placed between the stdlib imports (lines 22–24) and the third-party imports (line 28+), which triggers **ruff E402** on every import from line 28 onward. `E4` is selected in `pyproject.toml` and this file has no `per-file-ignores` exemption, so pre-commit CI will fail — same as the round-2 breakage. Fix: move the `logger = ...` assignment to after the last import in the file (currently line 49+). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
