dosubot[bot] commented on PR #40939: URL: https://github.com/apache/superset/pull/40939#issuecomment-4673797719
<!-- Answer --> Based on how other database drivers are constrained in Superset's `pyproject.toml`, the **dominant pattern is to use a version range with an upper bound** — e.g., `>=X.Y.Z, <A.B.C` — typically capping at the next major version [[1]](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/pyproject.toml#L109-L190). Examples: `pyathena[pandas]>=2, <3`, `mysqlclient>=2.1.0, <3`, `databricks-sql-connector>=2.0.2, <3`. The current StarRocks constraint (`>=1.0.0`) is a lower-bound-only spec, which is less common in this project. I'd recommend updating it to a range like `>=1.3.3, <2` to stay consistent with the majority of driver deps and avoid surprises if a breaking major version is released. This keeps the door open for patch/minor updates while protecting against unexpected API changes. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=reply-with-mention&utm_term=apache%2Fsuperset).* --- Docs are dead. Just use [Dosu](https://dosu.dev?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=static-docs-tagline&utm_term=apache%2Fsuperset). [](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=static-docs-feedback&utm_term=apache%2Fsuperset&message_id=d6b6af5f-12a4-403d-8d9d-2bea83ba5327) [](https://github.dosu.com/apache/superset?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=static-docs-ask-repo&utm_term=apache%2Fsuperset) [](https://app.dosu.dev/signup?referrer=openSource&source=github-footer&utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=static-docs-share-team&utm_term=apache%2Fsuperset) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
