jesperct opened a new pull request, #40952: URL: https://github.com/apache/superset/pull/40952
### SUMMARY The **Handlebars Template** and **CSS Styles** code editors in the Handlebars chart's Customize panel hard-coded the Ace `dark` theme, so they rendered as dark-mode islands inside a light UI (and would stay dark even when the rest of the app is light). This fixes the theme mismatch by deriving the editor theme from the active app theme via `useThemeMode()`, the same pattern already used by the deck.gl `TooltipTemplateEditor`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF | Before | After | |---|---| |  |  | ### TESTING INSTRUCTIONS 1. With a light UI theme, create or edit a Handlebars chart in Explore. 2. Open the **Customize** tab. 3. The **Handlebars Template** and **CSS Styles** editors should use a light editor theme that matches the surrounding UI (previously they were dark). 4. Switch the app to a dark theme and confirm the editors follow to the dark editor theme. Unit tests cover both editors in light and dark UI. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
