rusackas commented on PR #34238: URL: https://github.com/apache/superset/pull/34238#issuecomment-4676954389
Revisiting this, and seeing the same blocker as before, @iman-abc - this only edits iran.geojson directly, and that file gets regenerated from the Country Map GeoJSON Generator.ipynb notebook, so these ISO codes would get overwritten on the next spin of the notebook. The change needs to happen there. CI is also still red and the PR template is empty. One more thing while you're in there: where are the new codes sourced from? A few don't look like ISO 3166-2:IR (e.g. IR-00 for Markazi) and I want to make sure we're not swapping one mismatch for another. Anyway, this has been silent for a long time, so I'm going to close it now, but I'd be happy to revisit it if you want to touch it up and reopen it (or have us reopen it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
