rusackas commented on PR #35858:
URL: https://github.com/apache/superset/pull/35858#issuecomment-4676965706
Putting app.kubernetes.io/name and app.kubernetes.io/instance into
selectorLabels worries me — that helper feeds spec.selector.matchLabels on the
Deployments, which is immutable. It seems like helm upgrade would then fail
with "field is immutable" on any existing install, perhaps? I think the
k8s-recommended labels want to live in commonLabels (metadata only), and
selectorLabels should stay as-is. You've already got the commonLabels helper,
so it's mostly moving those two lines over. Separately, in service-flower.yaml
the include name has a trailing space — "supersetCeleryFlower.selectorLabels "
(both spots) — which won't resolve, and the {{- include }} lines there and in
service-ws.yaml are indented 2 instead of 4. The helm template should catch
those. Anyway, this has been silent for a long time, and we're moving more
towards the kubernetes operator approach. I'll close this now, but we're happy
to reopen/revisit if and when you are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
