dosubot[bot] commented on PR #40941: URL: https://github.com/apache/superset/pull/40941#issuecomment-4678158497
<!-- Answer --> Good question. I'd lean toward **keeping a wider range** (or at least not jumping straight to `>=3.8.0,<4`) for a couple of reasons: 1. **Superset's own policy** treats database connector changes as breaking changes and recommends that major driver upgrades be [carefully tested and, when in doubt, tied to a Superset major release](https://github.com/apache/superset/wiki/Semantic-Versioning). Jumping from `>=1.0.15,<2` all the way to `>=3.8.0,<4` skips the entire 2.x line and could break users still on older pyocient versions. 2. **The Ocient integration relies on specific pyocient APIs** — [TypeCodes](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/db_engine_specs/ocient.py#L196-L206), [geometry type classes](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/db_engine_specs/ocient.py#L88-L174), and query cancellation internals [[1]](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/db_engine_specs/ocient.py#L234-L238). Without confirming those APIs are stable across 1.x → 3.x, a narrow floor of `>=3.8.0` is risky. **Possible approaches:** - Widen the range to something like `>=1.0.15,<4` if pyocient 3.x is genuinely backward-compatible at the SQLAlchemy/DB-API level. - If 3.x introduced breaking changes, bump the floor but treat it as a breaking change (tag `risk:breaking-change`, update UPDATING.md, target a major Superset release) per the [breaking change process](https://github.com/apache/superset/wiki/Release-Process). - Ask the Ocient maintainers whether 1.x/2.x are still in use or effectively dead — if nobody is running them, the narrower range is fine. In short, unless we have confirmation that pyocient 1.x/2.x are completely EOL and no Superset users rely on them, a wider range (`>=1.0.15,<4`) is the safer default. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=reply-with-mention&utm_term=apache%2Fsuperset).* --- Share context across your team and agents. Try [Dosu](https://dosu.dev?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-tagline&utm_term=apache%2Fsuperset). [](https://app.dosu.dev/response-feedback?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-feedback&utm_term=apache%2Fsuperset&message_id=260915c5-3368-4690-a4d3-0479572e938e) [](https://github.dosu.com/apache/superset?utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-learn-repo&utm_term=apache%2Fsuperset) [](https://app.dosu.dev/signup?referrer=openSource&source=github-footer&utm_source=github&utm_medium=bot-comment&utm_campaign=github-comment-footer-20260415&utm_content=knowledge-infrastructure-add-team&utm_term=apache%2Fsuperset) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
