codeant-ai-for-open-source[bot] commented on code in PR #40853:
URL: https://github.com/apache/superset/pull/40853#discussion_r3396911855
##########
tests/unit_tests/mcp_service/chart/tool/test_update_chart.py:
##########
@@ -1344,3 +1345,292 @@ def
test_response_form_data_wraps_sql_metric_strings(self) -> None:
assert "<UNTRUSTED-CONTENT>" in m["sqlExpression"]
assert "<UNTRUSTED-CONTENT>" in m["label"]
assert "<UNTRUSTED-CONTENT>" not in m["optionName"]
+
+
+class TestBuildUpdatePayloadDatasetId:
+ """Tests for dataset_id support in _build_update_payload."""
+
+ def test_dataset_only_update_returns_datasource_fields(self):
Review Comment:
**Suggestion:** Add explicit type hints to this new test method signature,
including a `-> None` return annotation, to satisfy the fully-typed new code
rule. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added test method and it has no return type annotation.
Under the rule, new Python methods should be fully typed, so the omission is a
real violation.
</details>
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=57280eb33f5545a7ae531974d563d5f2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=57280eb33f5545a7ae531974d563d5f2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/mcp_service/chart/tool/test_update_chart.py
**Line:** 1353:1353
**Comment:**
*Custom Rule: Add explicit type hints to this new test method
signature, including a `-> None` return annotation, to satisfy the fully-typed
new code rule.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40853&comment_hash=6edc72de3cdbba86105e85ad98f781fb96727b15b3c103d4dc86ecc07441ba19&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40853&comment_hash=6edc72de3cdbba86105e85ad98f781fb96727b15b3c103d4dc86ecc07441ba19&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
