bito-code-review[bot] commented on PR #40978: URL: https://github.com/apache/superset/pull/40978#issuecomment-4684354622
<!-- Bito Reply --> To add test coverage for the dependent-filter scenario, you should create a test case in the `FilterValue` test suite that mocks the Redux state to simulate a parent filter with `defaultToFirstItem` enabled but no value selected. Verify that the child filter's data fetch action is not triggered until the parent's `dataMaskSelected` value is updated. You can use `jest` and `react-testing-library` to mock the `useSelector` hook and assert that `getChartDataRequest` is not called while the parent is in a pending state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
