bito-code-review[bot] commented on code in PR #40985:
URL: https://github.com/apache/superset/pull/40985#discussion_r3399948194
##########
superset-frontend/packages/superset-ui-core/src/components/Button/Button.stories.tsx:
##########
@@ -125,6 +125,11 @@ InteractiveButton.argTypes = {
options: buttonSizes,
control: { type: 'select' },
},
+ styleConfig: {
+ description:
+ 'Optional visual overrides (controlHeight, paddingInline, fontSize,
fontWeight, ctaMinWidth, ctaMinHeight, iconGap).',
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing borderRadius in description</b></div>
<div id="fix">
The `styleConfig` description lists 7 properties but `ButtonStyleConfig`
(types.ts:43-52) includes 8 properties — `borderRadius` is missing. Users
relying on Storybook controls will not know this option exists.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
---
superset-frontend/packages/superset-ui-core/src/components/Button/Button.stories.tsx
+++
superset-frontend/packages/superset-ui-core/src/components/Button/Button.stories.tsx
@@ -128,7 +128,7 @@ InteractiveButton.argTypes = {
styleConfig: {
description:
- 'Optional visual overrides (controlHeight, paddingInline, fontSize,
fontWeight, ctaMinWidth, ctaMinHeight, iconGap).',
+ 'Optional visual overrides (controlHeight, paddingInline, fontSize,
fontWeight, ctaMinWidth, ctaMinHeight, iconGap, borderRadius).',
control: { type: 'object' },
},
```
</div>
</details>
</div>
<small><i>Code Review Run #03fc85</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset-frontend/packages/superset-ui-core/src/components/DropdownButton/index.tsx:
##########
@@ -27,6 +27,7 @@ export const DropdownButton = ({
tooltip,
tooltipPlacement,
children,
+ styleConfig,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing unit tests for styleConfig</b></div>
<div id="fix">
The new `styleConfig` prop lacks unit test coverage. Per rule [6262], tests
should verify actual behavior logic — not just rendering. Add tests validating
each `styleConfig` property (controlHeight, fontSize, fontWeight, boxShadow)
and their defaults when the prop is omitted.
</div>
</div>
<small><i>Code Review Run #03fc85</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
