Abdulrehman-PIAIC80387 opened a new pull request, #40987:
URL: https://github.com/apache/superset/pull/40987

   ### SUMMARY
   
   Fixes #40962.
   
   \`cachetools\` is imported directly by \`superset.db_engine_specs.aws_iam\` 
(uses \`TTLCache\`), but it isn't declared in \`pyproject.toml\` — it has been 
reaching the install only transitively via \`google-auth\` (<2.53). 
\`google-auth\` 2.53+ dropped \`cachetools\` from its dependencies, so a fresh 
\`pip install apache-superset\` that resolves to current \`google-auth\` fails 
with:
   
   \`\`\`
   ModuleNotFoundError: No module named 'cachetools'
   \`\`\`
   
   Adding \`cachetools>=5.0, <7\` to the primary \`dependencies\` array makes 
the requirement explicit and unblocks the install.
   
   This follows the approach @hainenber outlined on the issue:
   
   > "the project should have google-auth pinned to v2.53 and then have a 
explicit declaration for cachetools dependency in pyproject.toml"
   
   This PR addresses the second half (the explicit \`cachetools\` declaration). 
I deliberately kept the change scoped to one line so it can land fast; the 
\`google-auth\` pinning and any lock-file regeneration can be a follow-up (or 
handled by the next weekly \`chore(deps): bump …\` automated PR).
   
   ### TESTING INSTRUCTIONS
   
   \`\`\`bash
   # In a clean virtualenv, with the lock file ignored:
   pip install -e . --no-deps
   pip install -e . --upgrade-strategy eager   # resolves google-auth>=2.53
   python -c "from superset.db_engine_specs import aws_iam; print('OK')"
   \`\`\`
   
   Before this change the \`import\` fails with \`ModuleNotFoundError: No 
module named 'cachetools'\`. After this change, \`cachetools\` is resolved 
explicitly and the import succeeds.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: #40962
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (please mention any potential downtime)
   - [ ] Migration is atomic, supports rollback & is backwards-compatible
   - [ ] Confirm DB migration upgrade and downgrade tested
   - [ ] Runtime introduces no new dependencies / changes existing dependencies
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to