rusackas commented on code in PR #40647:
URL: https://github.com/apache/superset/pull/40647#discussion_r3402404548
##########
tests/integration_tests/email_tests.py:
##########
@@ -208,6 +208,7 @@ def test_send_mime(self, mock_smtp, mock_smtp_ssl):
@mock.patch("smtplib.SMTP")
def test_send_mime_ssl(self, mock_smtp, mock_smtp_ssl):
current_app.config["SMTP_SSL"] = True
+ current_app.config["SMTP_SSL_SERVER_AUTH"] = False
Review Comment:
Good catch... added a setUp/tearDown save-and-restore for the SMTP config
keys this class mutates, so nothing leaks to later tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
