aminghadersohi commented on code in PR #40812:
URL: https://github.com/apache/superset/pull/40812#discussion_r3404158709
##########
superset/utils/pandas_postprocessing/pivot.py:
##########
@@ -123,6 +123,14 @@ def pivot( # pylint: disable=too-many-arguments
_("Pivot operation must include at least one aggregate")
)
+ # An empty list is semantically equivalent to no groupby columns. Normalise
+ # it to None so that all downstream branches (column_fill_value,
pivot_table,
+ # _restore_dropped_metric_columns) behave identically to the no-columns
case.
+ # This matters for categorical bar charts whose form_data carries
groupby=[]
+ # (the control panel default), causing series_columns=[] to be sent from
the
+ # frontend and an empty columns list to arrive here.
+ columns = columns or None
Review Comment:
sounds good. yeah will definitely test this. will dm you to make sure i test
it correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
