rebenitez1802 commented on PR #41002: URL: https://github.com/apache/superset/pull/41002#issuecomment-4694813843
My agent reviewer is flagging that: killing this deprecation noise is worth it, but I don’t think this change touches the path that emits it. query_object.py:223 is in QueryObject._rename_deprecated_fields(), only reachable via QueryObjectFactory on the /api/v1/chart/data path. BaseViz.query_obj()’s dict never builds a QueryObject — it goes through get_sqla_query, whose deprecation mapping (models/helpers.py:3061) is silent. So the legacy viz path never hits that log line. The prod logs back this up: every occurrence is _rename_deprecated_fields on a ThreadPoolExecutor thread (the modern data API), and the companion line at :231 (“series_limit_metric is already populated, replacing value with contents from timeseries_limit_metric”) only fires when the kwargs contain both keys — which query_obj() never emits. The deprecated keys are coming from the request queryContext, not this code. Real fix is likely client-side (buildQueryContext/saved query_context still sending the old keys), or defensively stripping them in QueryObjectFactory/schema before constructing QueryObject. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
