michael-s-molina commented on code in PR #41006: URL: https://github.com/apache/superset/pull/41006#discussion_r3406008592
########## superset-frontend/packages/superset-core/src/navigation/index.ts: ########## @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * @fileoverview Navigation namespace for Superset extensions (P3). + * + * Exposes the current application surface so extensions can react to route + * changes without polling. Entity-level context (chart, dashboard, dataset) + * is intentionally not included here — use the surface-specific namespace + * (`explore`, `dashboard`, `dataset`) to retrieve entity payloads. + */ + +import { Event } from '../common'; + +/** + * The set of top-level application surfaces. + * + * `'explore'`, `'dashboard'` and `'dataset'` are the single-entity + * editing/viewing surfaces where `explore.getCurrentChart()` / + * `dashboard.getCurrentDashboard()` / `dataset.getCurrentDataset()` resolve to a + * concrete entity. `'chart_list'`, `'dashboard_list'` and `'dataset_list'` are + * the browse/list surfaces, distinct from those because no single entity is + * active. `'sqllab'` is the SQL editor where `sqlLab.getCurrentTab()` resolves; + * `'query_history'` and `'saved_queries'` are the related SQL Lab browse pages, + * which are not the editor. `'other'` covers any route not explicitly enumerated. + */ +export type PageType = Review Comment: Maybe use Page? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
