rusackas commented on PR #40654: URL: https://github.com/apache/superset/pull/40654#issuecomment-4698367232
Thanks again @richardfogaca — all three caught and fixed in ad613d4. The empty-value one was the real bug: `get(..., DEFAULT)` now only defaults when the key is *absent*, so a present-but-empty value routes through `resolve_encryption_engine` and fails closed like any other typo. Added a unit test that `""` raises. Synced the SIP runbook with the five-step `UPDATING.md` version (post-restart second pass + the quiet-window note) and pointed it at `UPDATING.md` as canonical. And added `-> None` to the new `test_re_encrypt_secrets_*` functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
