rusackas commented on PR #36895: URL: https://github.com/apache/superset/pull/36895#issuecomment-4698985494
Thanks @vighneshtule, but this one still needs some tweaks. The PR Lint lint-check and sharded-jest-tests are failing (likely a snapshot/test affected by the new padding) Per CodeAnt please clamp the width/height passed to DataTable to >= 0, since subtracting padding from the 0 initial table size can yield negative dimensions. Ping us once it's green, and we'll come review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
