rusackas commented on PR #25176:
URL: https://github.com/apache/superset/pull/25176#issuecomment-4699053905
@allen-chang this one's been waiting on a rebase since 2023 and it's drifted
to ~3000 files / 4700 commits behind. The trouble is it's opened from your
fork's master, so master keeps merging in on top of it and a normal rebase
can't untangle it.
I'm going to go ahead and close it for now since it's unmergeable, but we
would be happy to review a cleaned up PR if possible.
One thing to fix when you re-do it: the DML block in execute() does a
substring match ("create " in query.lower(), etc.), so a read like SELECT *
FROM created_at or a column named update_ts would get falsely rejected. Worth
basing it on a proper parse rather than substrings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
