rusackas commented on PR #21769: URL: https://github.com/apache/superset/pull/21769#issuecomment-4699072672
Picked this back up @pengwk - it had drifted ~8k commits behind and gone conflicting. I rebased it onto current `master` and resolved the conflicts on your branch (force-pushed, your authorship kept). Worth knowing: master has since grown its own `changed_by` related filter and already lists `created_by` in `allowed_rel_fields`, so the net diff is smaller now. I kept that `changed_by` work and added `created_by` alongside it, ported the 'Created by' column + filter to the relocated `src/pages/SavedQueryList/index.tsx` (using the current `RelationOneMany` conventions), and the actual fix - gating the owner-only filter behind `can_access_all_queries` so admins see each other's saved queries - is intact. Mergeable again and CI's running. It's still a draft; want to mark it ready? A small unit test on the `SavedQueryFilter` gating would be a nice addition before merge, happy to add it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
