rusackas commented on PR #37517: URL: https://github.com/apache/superset/pull/37517#issuecomment-4699154990
Thanks for chasing down that '<' not supported between str and int crash @VinayaKumar12. Two things before I can dig in: pre-commit and the experimental playwright run are red (the latter might be flaky, or be fixed by the rebase). Also, I'm a little wary of special-casing server_page_length by name in the reducer, since any numeric freeForm control could hit the same thing. Could we coerce in the control itself (or harden the backend compare) so we fix the class of bug rather than one field? Curious what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
