rusackas commented on PR #36330: URL: https://github.com/apache/superset/pull/36330#issuecomment-4699156350
Thanks for unifying these @ompharate. Before I review, @sadpandajoe raised two good ones: hardcoding the icon to colorTextLabel looks like it drops the hover/active/disabled inheritance, and changing the default off bottomLeft could push left-aligned menus off screen. Could you take a look at those? playwright and test-storybook are also red. Ping me once it's settled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
