rusackas commented on PR #40821: URL: https://github.com/apache/superset/pull/40821#issuecomment-4699226581
@aminghadersohi thanks for the thorough pass! Pushed the LOW/NIT fixes in 9f7d2f9 - poll now captures the counts in-callback so the assertions use the same snapshot, switched to the typed `apiPutChart`, synced the layout `sliceName`, clarified the 1-based comment, and dropped the empty `groupby`. The `clear-all-filters.spec.ts` cleanup (LOW-3) is in a different file, so I left that for a separate follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
