rusackas commented on PR #38910:
URL: https://github.com/apache/superset/pull/38910#issuecomment-4700036644
Thanks for digging in on this one. Two things I want to understand before
merging... the detection requires not form_data.get("metrics"), but the native
filter form_data in nativeFilters/utils.ts sets metrics: ['count'], so wouldn't
that branch never fire for a real Select filter? And since it's gated behind a
new flag that's off by default, the stale-dropdown the issue describes isn't
fixed out of the box, operators have to flip
NATIVE_FILTER_QUERIES_USE_FILTER_STATE_TIMEOUT and set the timeout. Is that the
intended UX, or should this just be the default behavior? Curious if you tested
against an actual dynamic filter rather than the synthetic form_data in the
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
