rusackas commented on PR #38229: URL: https://github.com/apache/superset/pull/38229#issuecomment-4700061722
This LGTM, and hits the exact leak from #36492 (the check_and_warn_database_connection print). Tidies up the CLI and timeout paths while it's in there. Reads clean to me and the masking tests cover it. Will merge once CI's green after a rebase, if you don't mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
