rusackas commented on PR #39644: URL: https://github.com/apache/superset/pull/39644#issuecomment-4700104189
Thanks for fixing the FileNotFoundError regression. But dropping shell=True just trades the old # noqa: S602 for new S603/S607 hits, which is why pre-commit is red (check-env.py:52/107/108). So we'd still be suppressing bandit, just a different rule, on a local debug script run by the admin themselves with hard-coded commands. Given there's no untrusted input here, I'm still inclined to close rather than keep churning lint suppressions. What's the concrete threat you're guarding against, @orbisai0security, so we can make sure it's well-addressed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
