rusackas commented on PR #38615: URL: https://github.com/apache/superset/pull/38615#issuecomment-4700111451
Thanks again for digging into this @nitishagar, and the fix itself is clean (just revisiting it now). But back on #36244 I wasn't convinced this is actually a bug... if you import a dashboard you're technically the one creating that asset, so being added as an owner is at least defensible as intended behavior. Changing it quietly here flips that for everyone, and I'd want @dpgaspar or @michael-s-molina to weigh in on the security/ownership model before we do. The issue also describes a bigger expected behavior (copy-on-import for non-owners, splitting import from can_write) that this one-liner doesn't really address. Can we settle the "should this change at all" question on the issue first? If there's consensus it should, this is most of the way there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
