rusackas commented on PR #34980: URL: https://github.com/apache/superset/pull/34980#issuecomment-4701139542
@mistercrunch picking this back up — it's still red (playwright + a couple jest shards) on top of the merge conflicts, and there's a stray superset-frontend/test-file.xlsx that snuck into the commit. I keep landing on the same question: is it worth grinding the rebase, or should we carve this into scoped PRs (Node bump, storybook 8.6, the user-event async migration) that can each go green on their own? I'm inclined to close and split unless you want to drive the whole thing home... your call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
