fallintoplace commented on PR #40814:
URL: https://github.com/apache/superset/pull/40814#issuecomment-4701462300

   @rusackas Thanks for flagging. I checked Click’s signatures: the second 
positional argument is `file`, not `nl`; `nl` is the third positional argument 
or a keyword. The helper preserves `nl=False` for both `click.echo("msg", 
nl=False)` and `click.echo("msg", None, False)`, while intentionally forcing 
the output stream to stderr in stdio mode.
   
   The original lambda was not correct because after assignment it recursively 
called the patched `click.echo`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to