orbisai0security commented on PR #39646: URL: https://github.com/apache/superset/pull/39646#issuecomment-4701761863
Thanks for the thorough explanation, that makes sense. If the database connection configuration is already within the admin trust boundary, blanket-blocking private ranges is more likely to break legitimate setups than prevent a real attack. I'll keep the unprivileged-role angle in mind. If I find a concrete path where a Public/Gamma/sql_lab user can influence the token URI, I'll reopen with specifics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
