codeant-ai-for-open-source[bot] commented on code in PR #41052:
URL: https://github.com/apache/superset/pull/41052#discussion_r3413925511
##########
superset-frontend/src/SqlLab/components/SqlEditorTabHeader/index.tsx:
##########
@@ -40,6 +40,8 @@ import {
} from 'src/SqlLab/actions/sqlLab';
import { QueryEditor, SqlLabRootState } from 'src/SqlLab/types';
import { Icons, type IconType } from '@superset-ui/core/components/Icons';
+import { StandardModal } from 'src/components/Modal';
+import { Input } from 'antd';
Review Comment:
**Suggestion:** Replace the direct `antd` import with the approved Superset
UI wrapper import for `Input` (for example from `@superset-ui/core/components`
or `@superset-ui/core/components/Input`) to comply with frontend component
import rules. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The final file state still imports `Input` directly from `antd` in frontend
UI code.
This matches the custom rule that forbids direct Ant Design imports and
requires using `@superset-ui/core` or an approved wrapper instead.
</details>
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a03c3f6686d443568f7adb856acd0681&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a03c3f6686d443568f7adb856acd0681&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/SqlLab/components/SqlEditorTabHeader/index.tsx
**Line:** 44:44
**Comment:**
*Custom Rule: Replace the direct `antd` import with the approved
Superset UI wrapper import for `Input` (for example from
`@superset-ui/core/components` or `@superset-ui/core/components/Input`) to
comply with frontend component import rules.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41052&comment_hash=eb7c5140c02ae3d6682d40cd9005ec44fea19a57303e8157402b4a81496faefa&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41052&comment_hash=eb7c5140c02ae3d6682d40cd9005ec44fea19a57303e8157402b4a81496faefa&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
