bito-code-review[bot] commented on code in PR #41058: URL: https://github.com/apache/superset/pull/41058#discussion_r3415345789
########## docs/yarn.lock: ########## @@ -374,6 +410,11 @@ resolved "https://registry.npmjs.org/@babel/helper-globals/-/helper-globals-7.28.0.tgz"; integrity sha512-+W6cISkXFa1jXsDEdYA8HeevQT/FULhxzR99pxphltZcVaugps53THCeiWA8SguxxpSp3gKPiuYfSWopkLQ4hw== +"@babel/helper-globals@^7.29.7": + version "7.29.7" + resolved "https://registry.yarnpkg.com/@babel/helper-globals/-/helper-globals-7.29.7.tgz#f04a96fbd8473241b1079243f5b3f03a3010ab7b"; + integrity sha512-3nQVUAtvkKH9zahfWgw96Jc/uFOmjACE1kQz82E2lqWmHBgjzbNlsC22nuQTfahmWeQtTq5nQ/4Nnd2A1wj4zA== Review Comment: <div> <div id="suggestion"> <div id="issue"><b>CWE-10438: Manual Lock File Edit</b></div> <div id="fix"> Lock files should never be manually edited per project guidelines. Run 'yarn install' after updating the source dependency to regenerate yarn.lock with correct integrity hashes. (See also: [CWE-10438](https://cwe.mitre.org/data/definitions/10438.html)) </div> </div> <small><i>Code Review Run #c24244</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## docs/yarn.lock: ########## @@ -496,6 +569,13 @@ dependencies: "@babel/types" "^7.29.0" +"@babel/parser@^7.29.7": + version "7.29.7" + resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.29.7.tgz#837b87387cbf5ec5530cb634b3c622f68edb9334"; + integrity sha512-hnORnjP/1P/zFEndoeX+n+t1RwWRJiJpM/jO7FW32Kn9r5+sJB2JWOdYo4L6k78j15eCwY3Gm/7364B1EMwtNg== + dependencies: + "@babel/types" "^7.29.7" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Lock file manual edit</b></div> <div id="fix"> Lock file was manually edited, violating rule 10438. The @babel/parser@^7.29.7 entry should not be added directly to yarn.lock. Instead, add the dependency to package.json and run `yarn install` to regenerate the lock file with proper integrity hashes. </div> </div> <small><i>Code Review Run #c24244</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## docs/yarn.lock: ########## @@ -1214,6 +1316,14 @@ "@babel/helper-string-parser" "^7.27.1" "@babel/helper-validator-identifier" "^7.28.5" +"@babel/types@^7.29.7": + version "7.29.7" + resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.29.7.tgz#8005e31d82712ee7adaef6e23c63b71a62770a92"; + integrity sha512-4zBIxpPzowiZpusoFkyGVwakdRJUyuH5PxQ/PrqghfdFWWasvnCdPfQXHrenDai+gyLARulZjZowCOj6fjT4pA== + dependencies: + "@babel/helper-string-parser" "^7.29.7" + "@babel/helper-validator-identifier" "^7.29.7" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Lock file manual edit</b></div> <div id="fix"> Lock file was manually edited, violating rule 10438. The @babel/types@^7.29.7 entry should not be added directly to yarn.lock. Instead, add the dependency to package.json and run `yarn install` to regenerate the lock file with proper integrity hashes. </div> </div> <small><i>Code Review Run #c24244</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## docs/yarn.lock: ########## @@ -1172,6 +1252,15 @@ "@babel/parser" "^7.28.6" "@babel/types" "^7.28.6" +"@babel/template@^7.29.7": + version "7.29.7" + resolved "https://registry.yarnpkg.com/@babel/template/-/template-7.29.7.tgz#4d9d4004f645cdd304de958c725162784ecac700"; + integrity sha512-puq+Gf35oI24FeN11LkoUQFqv9uwNeWpxXZi/Ji3rRIoKAzKnxRaZ+Gkj0vKS9ZCiTESfng1N9LyOyXvo+m+Gg== + dependencies: + "@babel/code-frame" "^7.29.7" + "@babel/parser" "^7.29.7" + "@babel/types" "^7.29.7" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Lock file manual edit</b></div> <div id="fix"> Lock file was manually edited, violating rule 10438. The @babel/template@^7.29.7 entry should not be added directly to yarn.lock. Instead, add the dependency to package.json and run `yarn install` to regenerate the lock file with proper integrity hashes. </div> </div> <small><i>Code Review Run #c24244</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## docs/yarn.lock: ########## @@ -1198,6 +1287,19 @@ "@babel/types" "^7.29.0" debug "^4.3.1" +"@babel/traverse@^7.29.7": + version "7.29.7" + resolved "https://registry.yarnpkg.com/@babel/traverse/-/traverse-7.29.7.tgz#c47b07a41b95da0907d026b5dd894d98de7d2f2d"; + integrity sha512-EhlfNQtZ+NK22w5BM61ciuiq1m58ed33Wr1Xan//ZRTy6hgjnwyCffRYwzsGXdASJSUJ1guZILsErh1eQcl+zw== + dependencies: + "@babel/code-frame" "^7.29.7" + "@babel/generator" "^7.29.7" + "@babel/helper-globals" "^7.29.7" + "@babel/parser" "^7.29.7" + "@babel/template" "^7.29.7" + "@babel/types" "^7.29.7" + debug "^4.3.1" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Lock file manual edit</b></div> <div id="fix"> Lock file was manually edited, violating rule 10438. The @babel/traverse@^7.29.7 entry should not be added directly to yarn.lock. Instead, add the dependency to package.json and run `yarn install` to regenerate the lock file with proper integrity hashes. </div> </div> <small><i>Code Review Run #c24244</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
