codeant-ai-for-open-source[bot] commented on code in PR #37015:
URL: https://github.com/apache/superset/pull/37015#discussion_r3415912294
##########
scripts/check-env.py:
##########
@@ -162,10 +166,12 @@ def main(docker: bool, frontend: bool, backend: bool) ->
None: # noqa: C901
),
Requirement(
"docker-compose",
+ # docker-compose output may include 'v' in the version token or
have extra text
(Version("2.28.0"), Version("999.999.999")),
(Version("1.29.0"), Version("999.999.999")),
"docker",
"docker-compose --version",
+ lambda v: v.split()[-1].lstrip("v"),
),
Review Comment:
**🟠 Architect Review — HIGH**
The new docker-compose version post-processing uses the last whitespace
token from `docker-compose --version`, which for v1-style output like
`docker-compose version 1.29.2, build …` is the build hash rather than the
semantic version, causing `Invalid Version Format` for installations that are
within the declared supported range.
**Suggestion:** Parse docker-compose output by explicitly extracting the
semantic version token (e.g., the first token matching a version pattern, with
optional leading `v` and trailing comma removed) so both v1 (`docker-compose
version 1.29.2, build …`) and v2 (`Docker Compose version v2.28.0`) formats
correctly yield a comparable version.
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6d15c544ae1c42f99e2bb575bdde3b2e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6d15c544ae1c42f99e2bb575bdde3b2e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is an **Architect / Logical Review** comment left during a code review.
These reviews are first-class, important findings — not optional suggestions.
Do NOT dismiss this as a 'big architectural change' just because the title says
architect review; most of these can be resolved with a small, localized fix
once the intent is understood.
**Path:** scripts/check-env.py
**Line:** 169:175
**Comment:**
*HIGH: The new docker-compose version post-processing uses the last
whitespace token from `docker-compose --version`, which for v1-style output
like `docker-compose version 1.29.2, build …` is the build hash rather than the
semantic version, causing `Invalid Version Format` for installations that are
within the declared supported range.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
If a suggested approach is provided above, use it as the authoritative
instruction. If no explicit code suggestion is given, you MUST still draft and
apply your own minimal, localized fix — do not punt back with 'no suggestion
provided, review manually'. Keep the change as small as possible: add a guard
clause, gate on a loading state, reorder an await, wrap in a conditional, etc.
Do not refactor surrounding code or expand scope beyond the finding.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
