rusackas commented on PR #39460: URL: https://github.com/apache/superset/pull/39460#issuecomment-4711490896
Thanks @EnxDev and @aminghadersohi — pushed `887f3beef9` covering these. - **SliceAdder**: good catch on the dropped search — the debounce is created once now and reads `sortBy`/`userIdForFetch` from refs at fire time, so changing the sort mid-type no longer cancels the pending request. - **Markdown error boundary**: moved the `<ErrorBoundary>` to wrap the whole edit/preview ternary, so edit mode is covered again, not just preview. - **Dashboard `visibilitychange`**: routed `onVisibilityChange` (and the unmount `actions` cleanup) through refs so the mount-only listener can't fire a stale closure. - **Markdown undo/redo**: swapped the `useEffect` for a render-phase guard (the `getDerivedStateFromProps` equivalent) — no more one-frame flash of the old content. - **WithPopoverMenu**: the click/drag listeners key only on focus/`editMode` transitions now (ref'd handler) instead of re-binding on every `handleClick` change. - **UndoRedoKeyListeners**: kept Ctrl+Shift+Z→Redo (intentional — matches most editors) but restored the `keyCode` 90/89 fallback for non-Latin layouts, and added tests for the shift + keyCode branches. On `beforeunload`-on-unmount (@EnxDev): intentional. `applyCharts` re-runs each render and re-adds the listener whenever `hasUnsavedChanges` flips, so the unmount cleanup only drops it on actual unmount — left as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
