rusackas opened a new pull request, #41071:
URL: https://github.com/apache/superset/pull/41071
### SUMMARY
The SQL Lab left panel was rewritten from the flat `TableElement` schema
list to the `TableExploreTree` (react-arborist) tree. `TableElement` was
unplugged from `SqlEditorLeftBar` during that migration, but its files were
never removed — it survives in the repo referenced only by its own test, so it
compiles, its test stays green, and dead-code tooling treats the self-import as
a real reference. Nothing in the app renders it.
This removes that orphaned component and the redux surface that died with it:
- **`SqlLab/components/TableElement/`** (component + test) — only referenced
by itself; the live left bar renders `<TableExploreTree>` unconditionally (no
feature-flag fallback).
- **`syncTable` thunk** in `actions/sqlLab.ts` — its only consumer was
`TableElement`. The new tree refreshes schema via `fetchAndStoreTableSchema`
(`useTreeData`), not `syncTable`.
- **The `TableMetaData` interface local to `actions/sqlLab.ts`** — used only
by `syncTable`. (Unrelated: a separate `TableMetaData` in `hooks/apiResources`
is the live type imported everywhere else — that one is untouched.)
- The `describe('syncTable')` block in `actions/sqlLab.test.ts`.
**Deliberately kept** because they're still used by the new tree / table
preview:
- `ColumnElement` (used by `TableExploreTree/TreeNodeRenderer`, `types.ts`,
`fixtures.ts`)
- `ShowSQL` (used by `TablePreview`)
- `mergeTable` / `MERGE_TABLE` and its reducer (used by `addTable` and other
live flows)
Context: surfaced while triaging #38839, which fixed a refresh bug in
`TableElement` — a fix that can no longer reach users because the component is
dead. Closing that PR alongside this cleanup.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — pure dead-code removal, no user-facing change.
### TESTING INSTRUCTIONS
- `cd superset-frontend && npm run type` — no new errors.
- `npx jest src/SqlLab/actions/sqlLab.test.ts
src/SqlLab/reducers/sqlLab.test.ts src/SqlLab/components/SqlEditorLeftBar` —
green.
- Manually: open SQL Lab, pick a database/schema/table — the table tree and
schema refresh still work (they run through `TableExploreTree`, untouched here).
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Introduces new feature or API
- [x] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
