hy144328 commented on PR #39782: URL: https://github.com/apache/superset/pull/39782#issuecomment-4712824990
> Thanks for circling back on this, and for your patience. The if tzinfo is None guard with timezone.utc LGTM, and avoids the clobbering-aware-datetimes issue that the unconditional replace() in #40034 would hit. I'm good with this approach. I'm considering closing #40034 in favor of this one so we're not landing the same fix twice — feel free to rebase when possible (there's currently a conflict), and we can take that route. 🤞 @rusackas As suggested, I rebased in order to resolve the merge conflicts. Turned out to only be some noise at the import statements. I force-pushed the rebased branch, and double-checked that the testcase in question still passes (see description): ```python env TZ='US/Eastern' python3 -m pytest tests/unit_tests/models/core_test.py -k test_dttm_sql_literal ``` Ready whenever you are! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
