bito-code-review[bot] commented on PR #41077:
URL: https://github.com/apache/superset/pull/41077#issuecomment-4712834421
<!-- Bito Reply -->
The flagged issue is correct. Unconditionally exporting `FLASK_DEBUG=1` in
`docker/docker-bootstrap.sh` overrides any user-provided configuration,
preventing operators from disabling debug mode. To resolve this, you should
only set `FLASK_DEBUG` if it is not already defined.
### Proposed Fix
Modify `docker/docker-bootstrap.sh` to use conditional assignment:
```bash
# Only set FLASK_DEBUG if not already set by the environment
: ${FLASK_DEBUG:=1}
export FLASK_DEBUG
```
This ensures that if `FLASK_DEBUG` is provided via `docker/.env` or
`docker/.env-local`, that value is respected, while still defaulting to `1` if
it is unset.
Regarding other comments on this PR: the provided `pr_comments.csv` is
empty, so there are no other comments to address.
**docker/docker-bootstrap.sh**
```
# Only set FLASK_DEBUG if not already set by the environment
: ${FLASK_DEBUG:=1}
export FLASK_DEBUG
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
