hy144328 commented on PR #40276: URL: https://github.com/apache/superset/pull/40276#issuecomment-4713071356
> Just rebased the branch, but this is generally looking ready to approve to my eyes. Would love to have the bot comments addressed, but otherwise just waiting on a second opinion from @villebro @michael-s-molina @betodealmeida @dpgaspar @rusackas I have addressed the bot comments, and included their suggestions in the most recent commits. In particular, since the scope of this PR is focused on `select()` warnings ( see #40273 ), I originally did not pay a lot of attention to those warnings since they will be addressed by a subsequent PR eventually. Otherwise, I rebased and re-ran all unit tests, successfully. From my end, I think we are still good to go, and kick off the path to SQLAlchemy 2. :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
