rusackas commented on PR #38162: URL: https://github.com/apache/superset/pull/38162#issuecomment-4713422685
@aminghadersohi thanks for the careful read. Pinned the disabled state with a `toBeDisabled()` assertion and expanded the comment to spell out the disabled/0-badge trade-off — both in ed14e8b9d7. Left the `<Global>` block as-is since the styles are inert when nothing can open; happy to gate it on `popoverContent` too if you'd rather not pay the unused-CSS cost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
