bito-code-review[bot] commented on code in PR #41083:
URL: https://github.com/apache/superset/pull/41083#discussion_r3417228509


##########
pyproject.toml:
##########
@@ -144,7 +144,7 @@ dynamodb = ["pydynamodb>=0.4.2"]
 solr = ["sqlalchemy-solr >= 0.2.0"]
 elasticsearch = ["elasticsearch-dbapi>=0.2.13, <0.3.0"]
 exasol = ["sqlalchemy-exasol>=2.4.0, <8.0"]
-excel = ["xlrd>=1.2.0, <1.3"]
+excel = ["xlrd>=2.0.2, <2.1"]

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Inconsistent dependency versions</b></div>
   <div id="fix">
   
   The `requirements/base.txt` and `requirements/development.txt` files still 
pin `xlrd==2.0.1`, which is inconsistent with the updated `xlrd>=2.0.2, <2.1` 
in pyproject.toml. Per BITO.md rule [12146], lock files should be regenerated 
through official package manager workflows after updating manifest files.
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #114d8d</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a 
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to