bito-code-review[bot] commented on code in PR #41088:
URL: https://github.com/apache/superset/pull/41088#discussion_r3417227982
##########
pyproject.toml:
##########
@@ -177,7 +177,7 @@ ocient = [
"shapely",
"geojson",
]
-oracle = ["cx-Oracle>8.0.0, <8.4"]
+oracle = ["cx-Oracle>=8.3.0, <8.4"]
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Deprecated cx-Oracle vs oracledb mismatch</b></div>
<div id="fix">
The `oracle` extra specifies `cx-Oracle>=8.3.0,<8.4` but the codebase
already migrated to `oracledb` (see `superset/db_engine_specs/oracle.py` line
38: `"pypi_packages": ["oracledb"]`). `cx_Oracle` was deprecated by Oracle in
2022, only supports Python ≤3.10, and has known build failures on Python 3.11+.
This dependency is incompatible with Superset's `requires-python = ">=3.10"`
and will fail to install or build on supported Python versions.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- pyproject.toml (line 180) ---
180:-oracle = ["cx-Oracle>=8.3.0, <8.4"]
180:+oracle = ["oracledb>=2.0.0,<3"]
```
</div>
</details>
</div>
<small><i>Code Review Run #ec356a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
