bito-code-review[bot] commented on code in PR #41092:
URL: https://github.com/apache/superset/pull/41092#discussion_r3417234975
##########
docs/yarn.lock:
##########
@@ -14499,15 +14499,15 @@ types-ramda@^0.30.1:
dependencies:
ts-toolbelt "^9.6.0"
-typescript-eslint@^8.60.1:
- version "8.60.1"
- resolved
"https://registry.yarnpkg.com/typescript-eslint/-/typescript-eslint-8.60.1.tgz#13db05c6eabb89669deec44545b788a0e9aee640";
- integrity
sha512-6m5hkkRAp8lKvhVpcprAIn5KkehQEh+47oHH2VGnExEh7dhNxXlg6GPAOIu6TxbVQxhebrJDvjl3020ooiWCMA==
+typescript-eslint@^8.61.0:
+ version "8.61.0"
+ resolved
"https://registry.yarnpkg.com/typescript-eslint/-/typescript-eslint-8.61.0.tgz#6927fb94f5f29623e370d33fd9fa61f15d6d996b";
+ integrity
sha512-8y31Rd0eGTrDKqhy6vT0HtzhN+YLjQizwX3aA3hPXP/ynSfnrBXcQY5IzsP9/DM7+klX4IUncZZjkchP0z+rUw==
dependencies:
- "@typescript-eslint/eslint-plugin" "8.60.1"
- "@typescript-eslint/parser" "8.60.1"
- "@typescript-eslint/typescript-estree" "8.60.1"
- "@typescript-eslint/utils" "8.60.1"
+ "@typescript-eslint/eslint-plugin" "8.61.0"
+ "@typescript-eslint/parser" "8.61.0"
+ "@typescript-eslint/typescript-estree" "8.61.0"
+ "@typescript-eslint/utils" "8.61.0"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>BITO-10438: Manual lock file edit</b></div>
<div id="fix">
Lock files (`yarn.lock`) should never be manually edited. Per BITO.md rules
10438 and 12146, update `package.json` and run `yarn install` to regenerate
lock files. The `package.json` at `docs/package.json:112` already specifies the
correct version `^8.61.0`, so simply running `yarn install` in the docs
directory will regenerate the lock file properly with correct integrity hashes.
</div>
</div>
<small><i>Code Review Run #e66d34</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/yarn.lock:
##########
@@ -4922,110 +4922,110 @@
dependencies:
"@types/yargs-parser" "*"
-"@typescript-eslint/[email protected]",
"@typescript-eslint/eslint-plugin@^8.59.3":
- version "8.60.1"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-8.60.1.tgz#c1060bb8fa4be80624d3f3dec8dd9caca373af76";
- integrity
sha512-JQ4S5GB0tfjO8BuJ4fcX+HodkzJjYBV+7OJ+wLygaX7OGQ7FudyHL4NSCA6ob+w3Yn+5MkKIozOwQhXeM7opVg==
+"@typescript-eslint/[email protected]",
"@typescript-eslint/eslint-plugin@^8.59.3":
+ version "8.61.0"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-8.61.0.tgz#db20271974b94a3a54d3b9544e5f5b3481448400";
+ integrity
sha512-bFNvl9ZczlVb+wR2Akszf3gHfKVj/8WanXaGJ3UstTA7brNKg0cNdk6X1Psu5V7MZ2oQtzZKOEzIUehaoxbDGw==
dependencies:
"@eslint-community/regexpp" "^4.12.2"
- "@typescript-eslint/scope-manager" "8.60.1"
- "@typescript-eslint/type-utils" "8.60.1"
- "@typescript-eslint/utils" "8.60.1"
- "@typescript-eslint/visitor-keys" "8.60.1"
+ "@typescript-eslint/scope-manager" "8.61.0"
+ "@typescript-eslint/type-utils" "8.61.0"
+ "@typescript-eslint/utils" "8.61.0"
+ "@typescript-eslint/visitor-keys" "8.61.0"
ignore "^7.0.5"
natural-compare "^1.4.0"
ts-api-utils "^2.5.0"
-"@typescript-eslint/[email protected]", "@typescript-eslint/parser@^8.60.1":
- version "8.60.1"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-8.60.1.tgz#a9d7f30850384d34b41f4687dd8944823c09e289";
- integrity
sha512-A0M6ua6H252bVjPvvtSgl2QA4+ET9S5Mtkb2GDyTxIhH/C4qDItT7RQNO5PhMC6NXGYXOR9dIalcDDgBKT7oFA==
+"@typescript-eslint/[email protected]", "@typescript-eslint/parser@^8.60.1":
+ version "8.61.0"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-8.61.0.tgz#1afe73c9ccce16b7a26d6b95f9400b0ccc34af87";
+ integrity
sha512-5B7PfA2e1NQGCnDHd/0lW7W3gvp3d59Ryw54FYO8Uswxo9f6ikw3AZV+Xj/TvpImmpsiYyUqAfhC6kJID1jF6w==
dependencies:
- "@typescript-eslint/scope-manager" "8.60.1"
- "@typescript-eslint/types" "8.60.1"
- "@typescript-eslint/typescript-estree" "8.60.1"
- "@typescript-eslint/visitor-keys" "8.60.1"
+ "@typescript-eslint/scope-manager" "8.61.0"
+ "@typescript-eslint/types" "8.61.0"
+ "@typescript-eslint/typescript-estree" "8.61.0"
+ "@typescript-eslint/visitor-keys" "8.61.0"
debug "^4.4.3"
-"@typescript-eslint/[email protected]":
- version "8.60.1"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/project-service/-/project-service-8.60.1.tgz#eb29712f58d72c222fc727162e92f2ab4670971b";
- integrity
sha512-eXkTH2bxmXlqD1RnOPmLZ9ZM9D3VwSx04JOwBnP9RQ+yUA5a2Mu7SfW8uaV2Aon53NJzZlZYuX7tn91Izf+xaw==
+"@typescript-eslint/[email protected]":
+ version "8.61.0"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/project-service/-/project-service-8.61.0.tgz#417a2feac32e8ebd336d63f068c3b42b736ea1ac";
+ integrity
sha512-DV42F7MLJO6Rax7SK1yg43tcnEfGUrurSpSxKuVX+a3RCTzBlH3fuxprrOJXKCJGAaw82xXocikJ0uQaqwXgGA==
dependencies:
- "@typescript-eslint/tsconfig-utils" "^8.60.1"
- "@typescript-eslint/types" "^8.60.1"
+ "@typescript-eslint/tsconfig-utils" "^8.61.0"
+ "@typescript-eslint/types" "^8.61.0"
debug "^4.4.3"
-"@typescript-eslint/[email protected]":
- version "8.60.1"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-8.60.1.tgz#2f875962eaad0a0789cc3c36aea9b4ddeb2dd9c8";
- integrity
sha512-gvI5OQoptnxQnchOirukCuQ55svJSTuD/4k5+pC267xyBtYry748R9/c3tYUzb/iE6RZfllRz2lVulLCHkTm4w==
+"@typescript-eslint/[email protected]":
+ version "8.61.0"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-8.61.0.tgz#93c2520d05653fe65eb9ee98efc74fd0134a7852";
+ integrity
sha512-IWdXFHFSb6mlC3HPc7QsLDm5zYEbUla6trDEHf32D3/dnuUyXd87plScSNXSbm0/RxMvObpI17sv/EDTGrGZkA==
dependencies:
- "@typescript-eslint/types" "8.60.1"
- "@typescript-eslint/visitor-keys" "8.60.1"
+ "@typescript-eslint/types" "8.61.0"
+ "@typescript-eslint/visitor-keys" "8.61.0"
-"@typescript-eslint/[email protected]":
- version "8.60.1"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/tsconfig-utils/-/tsconfig-utils-8.60.1.tgz#bee8b942a13679a878101c9c74577d732062ed93";
- integrity
sha512-nh8w4qAteiKuZu3pSSzG/yGKpw0OlkrKnzFmbVRenKaD4qc+7i1GrmZaLVkr8rk4uipiPGMOW4YsM6WmKZ5CvA==
-
-"@typescript-eslint/tsconfig-utils@^8.60.1":
+"@typescript-eslint/[email protected]":
version "8.61.0"
resolved
"https://registry.yarnpkg.com/@typescript-eslint/tsconfig-utils/-/tsconfig-utils-8.61.0.tgz#05d6e3ff20001674ebcd22d03dac29ee448043ba";
integrity
sha512-O5Amvdv9ztMpxpf+vmFULGG78IE6Qwdr3bCGvqwG4nwc9H2qXkOYJJnRbRHyMkQTjv1d03olqwwwzHLMqpFePQ==
-"@typescript-eslint/[email protected]":
- version "8.60.1"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/type-utils/-/type-utils-8.60.1.tgz#1ae45f0f2a701354beea4a58c2161e40a5e3c379";
- integrity
sha512-sdwTrpjosW7ANQYJ39ZBF1ZyEMEGVB2UsikrserVM/30a/F1dTLnu9bGxEdosugyu5caigjLrR2qiD11asjI1A==
+"@typescript-eslint/tsconfig-utils@^8.61.0":
+ version "8.61.1"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/tsconfig-utils/-/tsconfig-utils-8.61.1.tgz#ca88080e0cf191d49516d7f300b67aa090d2254f";
+ integrity
sha512-UN/H4di+OO7EWx2ovME+8t31YO+KVnK0RRKEHR3kOt21/Ay8BOq3M1OMvWs5vNiqcFCYGYoxK3MXPZzmMUE+yg==
+
+"@typescript-eslint/[email protected]":
+ version "8.61.0"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/type-utils/-/type-utils-8.61.0.tgz#50219b57e6b89cecfb1a15f093b15ec9ee019974";
+ integrity
sha512-TuBiQYIkd97yBfInHCTKVYMbX4kvEmpOEuixIuzCU9p8BGT1SfyyO0d0IfDMbPIHcjn/hWnusUX5e8v5Xg+X8A==
dependencies:
- "@typescript-eslint/types" "8.60.1"
- "@typescript-eslint/typescript-estree" "8.60.1"
- "@typescript-eslint/utils" "8.60.1"
+ "@typescript-eslint/types" "8.61.0"
+ "@typescript-eslint/typescript-estree" "8.61.0"
+ "@typescript-eslint/utils" "8.61.0"
debug "^4.4.3"
ts-api-utils "^2.5.0"
-"@typescript-eslint/[email protected]":
- version "8.60.1"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/types/-/types-8.60.1.tgz#ccdc482ba9e17f9723a10ce240b5e67dad3046c4";
- integrity
sha512-4h0tY8ppCkdCzcrl2YM5M3my0xsE1Tf8om3owEu5oPWmXwkKRmk0j0LGDzYBGUcAlesEbxBhazqu/K4cu3Ug7w==
-
-"@typescript-eslint/types@^8.60.1":
+"@typescript-eslint/[email protected]":
version "8.61.0"
resolved
"https://registry.yarnpkg.com/@typescript-eslint/types/-/types-8.61.0.tgz#0ddb46e012a4288292950bdd253db42f278ce64d";
integrity
sha512-9QTQpZ5Iin4CdIodfbDQFSeiSJKidgYJYug1P9CC2xWgUTvlmixViqDZNciMjwLBZyJnG4tGmPl97rVAFb1AJg==
-"@typescript-eslint/[email protected]":
- version "8.60.1"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-8.60.1.tgz#016630b119228bf483ddc652703a6a038f3fdd74";
- integrity
sha512-alpRkfG8hlVE5kdJW2GkfgDgXxold3e8e4l6EnmhRmRLbekgAPCCGDVD++sABy9FcgPFroq+uFcCSM1vR57Cew==
+"@typescript-eslint/types@^8.61.0":
+ version "8.61.1"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/types/-/types-8.61.1.tgz#0c51f518e4e6848371a1c988e859d59eb7522d5a";
+ integrity
sha512-G+CRlPqLv7Bz1IZVs03x5K59F1veqL0EJUROAdGhKsEq8qOiRiZbI+HUojPq5l0fEGOKModD9br6lObhB8zkoA==
+
+"@typescript-eslint/[email protected]":
+ version "8.61.0"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-8.61.0.tgz#98ca47260bbf627fc28f018b3a0abf00e3090690";
+ integrity
sha512-42zatd5qSvvcV1JdDBCLxYRznvP4eIHpPoZXdkPFnAmanA4FuZ5dibSnCBggY8hQnqajPpoGjXFdZ7fIJKQnlA==
dependencies:
- "@typescript-eslint/project-service" "8.60.1"
- "@typescript-eslint/tsconfig-utils" "8.60.1"
- "@typescript-eslint/types" "8.60.1"
- "@typescript-eslint/visitor-keys" "8.60.1"
+ "@typescript-eslint/project-service" "8.61.0"
+ "@typescript-eslint/tsconfig-utils" "8.61.0"
+ "@typescript-eslint/types" "8.61.0"
+ "@typescript-eslint/visitor-keys" "8.61.0"
debug "^4.4.3"
minimatch "^10.2.2"
semver "^7.7.3"
tinyglobby "^0.2.15"
ts-api-utils "^2.5.0"
-"@typescript-eslint/[email protected]":
- version "8.60.1"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-8.60.1.tgz#31cf566095602d9fe8ad91837d2eb520b8de762b";
- integrity
sha512-h2MPBLoNtjc3qZWfY3Tl51yPorQ2McHn8pJfcMNTcIvrrZrr90Ykffit0yjrPFWQcRcUxzH20+6OcVdW4yHtUg==
+"@typescript-eslint/[email protected]":
+ version "8.61.0"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-8.61.0.tgz#ed3546a052787e84ea6c5064d0919fc5eea8522f";
+ integrity
sha512-3bzFt7ImFMW/jVYwJamDoe/dMOdFLSC6pom6rRjdh4SZJEYupyMzem8e7vKZLclLfpHjlwSAXOUxtKxGXUiLqA==
dependencies:
"@eslint-community/eslint-utils" "^4.9.1"
- "@typescript-eslint/scope-manager" "8.60.1"
- "@typescript-eslint/types" "8.60.1"
- "@typescript-eslint/typescript-estree" "8.60.1"
+ "@typescript-eslint/scope-manager" "8.61.0"
+ "@typescript-eslint/types" "8.61.0"
+ "@typescript-eslint/typescript-estree" "8.61.0"
-"@typescript-eslint/[email protected]":
- version "8.60.1"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-8.60.1.tgz#165d1d8901137b944efaf18f00ab5ecb57f06995";
- integrity
sha512-EbGRQg4FhrmwLodl+t3JNAnXHWVr9Vp+Zl1QBZVPY4ByfkzIT8cX3K6QWODHtkIZqqJVEWvhHSx3v5PDHsaQag==
+"@typescript-eslint/[email protected]":
+ version "8.61.0"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-8.61.0.tgz#39b4e1ab8936d23bea973d39fd092f9aa21f275e";
+ integrity
sha512-QVLZu3ZPQEE+HICQyAMZ2yLQhxf0meY/wx6Hx14YcTNj13JB3qHlX3lJ02L3fLGHgERRH71kvYDwiXIguT3AjQ==
dependencies:
- "@typescript-eslint/types" "8.60.1"
+ "@typescript-eslint/types" "8.61.0"
eslint-visitor-keys "^5.0.0"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Manual lock file edit without manifest update</b></div>
<div id="fix">
Lock file manually edited without updating docs/package.json. The manifest
still references '^8.59.3' while the lock file now resolves to '8.61.0'. Manual
lock edits can corrupt integrity hashes and cause environment-specific
resolution. Update package.json and regenerate via 'yarn install'.
</div>
</div>
<small><i>Code Review Run #e66d34</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
