sadpandajoe commented on code in PR #40832:
URL: https://github.com/apache/superset/pull/40832#discussion_r3417282103
##########
superset-frontend/src/dashboard/components/Header/index.tsx:
##########
@@ -721,6 +721,7 @@ const Header = (): JSX.Element => {
<Button
css={discardBtnStyle}
buttonSize="small"
+ disabled={!hasUnsavedChanges}
Review Comment:
@yousoph @kasiazjc with the Save and Discard both disabled if there are no
changes, the header now has no way to exit edit mode. Are we okay with that or
do we want to add another button to close or exit? Asking before I approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
