eschutho opened a new pull request, #41118:
URL: https://github.com/apache/superset/pull/41118
## Summary
`np.NaN` (capital N) was deprecated in NumPy 1.24 and **removed in NumPy
2.0**. The production environment uses NumPy 1.26.4, where accessing `np.NaN`
emits a `DeprecationWarning`.
Two call sites remained unfixed in master:
- `superset/models/helpers.py`: placeholder DataFrame in
`processing_time_offsets` when an offset query returns no rows
- `tests/unit_tests/pandas_postprocessing/test_resample.py`: test fixture
data
### What changed
Replaced all four `np.NaN` occurrences with `np.nan` (the canonical
lowercase alias). Functionally identical — both are `float('nan')` — but
`np.nan` is the stable, non-deprecated form.
No behavior change. The placeholder rows still hold `NaN` values; only the
attribute access path changed.
## Test plan
- [ ] Pre-commit hooks pass (mypy, ruff, pylint — all green on this branch)
- [ ] `pytest tests/unit_tests/pandas_postprocessing/test_resample.py` —
existing test passes unchanged
- [ ] `pytest tests/integration_tests/query_context_tests.py -k time_offset`
— validates `processing_time_offsets` empty-df path
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
