rusackas opened a new pull request, #41123:
URL: https://github.com/apache/superset/pull/41123

   ### SUMMARY
   
   Tightens the SQLAlchemy requirement from `>=1.4, <2` to `>=1.4.43, <2`.
   
   **Why:** #41122 migrates the Oracle engine spec off the deprecated cx-Oracle 
driver to python-oracledb, which SQLAlchemy exposes through the 
`oracle+oracledb` dialect. That dialect was **added in SQLAlchemy 1.4.43** 
(released 2022-11-04). The previous `>=1.4` floor allowed 1.4.0–1.4.42, where 
the dialect does not exist, so a downstream resolver could legally install a 
SQLAlchemy that can't connect to Oracle at all and fail at runtime rather than 
at install time.
   
   **Risk / tradeoffs:**
   - Effectively zero for the pinned environment: `requirements/base.txt` 
already resolves `sqlalchemy==1.4.54`, so nothing changes for anyone installing 
from the lockfile or a built image.
   - The only group affected is downstream projects that install 
`apache-superset` as a library with their own resolver and were somehow pulling 
a SQLAlchemy older than 1.4.43. Those are already broken in subtle ways against 
current Superset; this just turns a runtime failure into an honest 
dependency-resolution constraint.
   - Still capped at `<2`, so this does not pull anyone onto SQLAlchemy 2.x.
   
   This can land before or after #41122; they're independent, but together they 
make the Oracle path correct end to end.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A
   
   ### TESTING INSTRUCTIONS
   
   - `pip install "apache-superset"` continues to resolve SQLAlchemy 1.4.54.
   - Attempting to constrain SQLAlchemy below 1.4.43 now fails resolution 
instead of installing a version without the `oracle+oracledb` dialect.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to