rusackas commented on PR #36076: URL: https://github.com/apache/superset/pull/36076#issuecomment-4721974823
Thanks for sticking with this @ysinghc! The gap is real... `ChartPutSchema.query_context` has zero validation on `master`, so tightening it makes sense. What I'm chewing on: this rejects the bad `query_context` at save time, but doesn't get at *why* the frontend produces one missing `datasource`/`queries` in the first place. If that's a frontend bug in `buildQueryContext` running on partial `form_data`, then this flips the failure from "saves but errors later" into "won't save at all" until the generation side is fixed too. And the original report mentions native filters hitting this, which live in the dashboard's `json_metadata` rather than going through the chart API, so I don't think this PR catches that path. @betodealmeida do you think save-time validation is the right layer here, or should we be fixing the generation side? You've got way more context on this corner than I do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
