bito-code-review[bot] commented on PR #41131:
URL: https://github.com/apache/superset/pull/41131#issuecomment-4724502471
<!-- Bito Reply -->
The observation is correct. The docstring in the regression test
`test_apply_dashboard_filter_context_does_not_duplicate_filters` currently
states that dashboard filters should be applied *only* via `extra_form_data`,
but the implementation of `apply_dashboard_filter_context` explicitly moves
them into `query['filters']` while removing them from `extra_form_data` to
prevent duplication issues in Jinja templates. Updating the docstring to
reflect that `extra_form_data` is the source of truth for the *initial* state,
but that the helper function manages the distribution of these filters into the
query object, would align the documentation with the actual behavior.
**tests/unit_tests/charts/test_chart_data_api.py**
```
"""
Regression test for the ``filters_dashboard_id`` parameter.
A dashboard's filters are initially provided via extra_form_data, but are
moved into query["filters"] by apply_dashboard_filter_context to ensure
correct Jinja templating behavior and avoid duplicated values.
"""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
