bito-code-review[bot] commented on PR #41129:
URL: https://github.com/apache/superset/pull/41129#issuecomment-4724842063
<!-- Bito Reply -->
The suggestion to add a docstring to the new test function is correct and
improves code documentation. You can resolve this by adding a docstring that
describes the test's purpose, as shown below:
```python
def test_scarf_analytics_is_exposed_to_frontend_config() -> None:
"""Verify that SCARF_ANALYTICS is exposed in frontend config keys."""
# Exposed at runtime so pre-built images can opt out via the
SCARF_ANALYTICS
# config/env var (the webpack build-time flag cannot be changed there).
from superset.views.base import FRONTEND_CONF_KEYS
assert "SCARF_ANALYTICS" in FRONTEND_CONF_KEYS
```
I have checked the other comments on this PR, and there are no other pending
review comments to address. Please let me know if you would like me to assist
with anything else.
**tests/unit_tests/views/test_base.py**
```
def test_scarf_analytics_is_exposed_to_frontend_config() -> None:
"""Verify that SCARF_ANALYTICS is exposed in frontend config keys."""
# Exposed at runtime so pre-built images can opt out via the
SCARF_ANALYTICS
# config/env var (the webpack build-time flag cannot be changed there).
from superset.views.base import FRONTEND_CONF_KEYS
assert "SCARF_ANALYTICS" in FRONTEND_CONF_KEYS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
