bito-code-review[bot] commented on PR #41130:
URL: https://github.com/apache/superset/pull/41130#issuecomment-4725889294
<!-- Bito Reply -->
The flagged issue is correct. The new test method
`test_security_fab_views_have_valid_list_template` lacks type hints for `self`
and the return value, which is required by the project's custom rule for new
code.
You can resolve this by updating the method signature as follows:
```python
def test_security_fab_views_have_valid_list_template(self) -> None:
```
There are no other comments on this pull request to address.
**tests/integration_tests/core_tests.py**
```
def test_security_fab_views_have_valid_list_template(self) -> None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
