rusackas opened a new pull request, #41135:
URL: https://github.com/apache/superset/pull/41135

   ### SUMMARY
   
   ag-Grid's default cell style collapses runs of whitespace, so values that 
depend on significant spacing - e.g. [option 
symbols](https://en.wikipedia.org/wiki/Option_symbol) and other financial 
identifiers - get rendered with the spaces squashed, misrepresenting the 
underlying data. This applies `white-space: pre` to `.ag-cell-value` in the 
shared `GridTable` (used by SQL Lab results and the Explore data panel) so the 
displayed value matches what's actually in the cell.
   
   Single-line behavior is preserved (`pre` rather than `pre-wrap`), so row 
heights and column sizing are unchanged - only the previously-collapsed 
whitespace is now retained.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   See the original report in #36042 for before/after visuals of the collapsed 
vs. preserved whitespace.
   
   ### TESTING INSTRUCTIONS
   
   1. In SQL Lab, run a query that returns a value with multiple 
internal/trailing spaces, e.g. `SELECT 'F     ' AS osi_symbol`.
   2. Before this change the spaces collapse to one; after, all five spaces are 
preserved in the result cell.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #36042
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to