rusackas commented on PR #38126: URL: https://github.com/apache/superset/pull/38126#issuecomment-4732393626
@YousufFFFF thanks for digging into this. The `(layer as any)` cast trips our no-`any` rule, and approximating a month as 30 days / a year as 365 means the shifted annotation won't line up with the actual data, which is the whole point. Can we lean on the existing calendar-aware time-shift logic rather than re-deriving it in ms? Also needs a rebase and bot comments addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
