eschutho commented on PR #41080: URL: https://github.com/apache/superset/pull/41080#issuecomment-4734695185
Thanks for the thorough review! **Functional gap (multi-tab partial PDF)** — great catch. I've pushed a second commit that changes `_get_screenshots()` to raise `ReportScheduleScreenshotFailedError` immediately on the first `None` result instead of silently dropping it. This way the "do not send bad output" guarantee holds for multi-tab reports too. **`-> None` annotation** — added to the test method in the same commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
